rusackas opened a new pull request, #34742:
URL: https://github.com/apache/superset/pull/34742
## Summary
This PR fixes the Range filter to properly handle decimal values.
Previously, the slider component defaulted to integer steps, making it
impossible to select decimal values through the slider interface.
Fixes #34737
## Changes
- Added dynamic step size calculation based on the data range
- For small decimal ranges (< 1), calculates appropriate decimal precision
- For larger ranges, uses steps that provide approximately 100 increments
- Ensures step values are "nice" numbers (0.001, 0.01, 0.1, 1, 10, etc.)
- Added comprehensive tests for decimal value handling
## Test Plan
1. Create a dataset with a decimal column (e.g., values between 0.03 and
1.08)
2. Add a Range filter for that column to a dashboard
3. Verify that the slider now allows selecting decimal values
4. Test with various ranges:
- Small decimals (0.001 to 0.01)
- Medium decimals (0.03 to 1.08)
- Large ranges (0 to 1000000)
- Negative decimals (-1.5 to 2.5)
All new tests have been added and are passing:
```bash
npm run test -- src/filters/components/Range/RangeFilterPlugin.test.tsx
```
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
