rusackas opened a new pull request, #34760:
URL: https://github.com/apache/superset/pull/34760
## Summary
Fixes #33335
Virtual datasets with names that don't contain a period (no schema prefix)
were not displaying correctly in the chart list. The dataset name would
disappear entirely instead of showing the full name.
### Root Cause
PR #29944 introduced logic to show only the dataset name (without schema) in
the chart list for better readability. However, the implementation assumed all
dataset names would follow the `schema.name` format and used `split('.')[1]` to
extract the name. When a dataset had no schema (no period in the name), this
would return `undefined`, causing the name to disappear.
### Solution
Updated the dataset name extraction logic to:
- Check if the name contains a period
- If yes: extract everything after the first period (handles names with dots
correctly)
- If no: use the full name as-is
## Test Plan
✅ Added comprehensive unit tests covering:
- Dataset names with schema prefix (`public.test_dataset`)
- Dataset names without schema (`Jinja 5`)
- Dataset names containing dots (`schema.table.with.dots`)
✅ All existing tests pass
✅ Pre-commit checks pass
## Manual Testing
1. Create a virtual dataset with a name like "Jinja 5" (no period)
2. Navigate to the Charts list
3. Verify the dataset name displays correctly in the Dataset column
4. Verify the tooltip shows the full name on hover
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
