msyavuz commented on code in PR #34642:
URL: https://github.com/apache/superset/pull/34642#discussion_r2287629699
##########
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/index.tsx:
##########
@@ -119,9 +123,13 @@ export default function
AdhocFilterEditPopoverSqlTabContent({
margin-top: ${theme.sizeUnit * 4}px;
`}
>
- <SQLEditor
- ref={aceEditorRef}
- keywords={keywords}
+ <SQLEditorWithValidation
+ onRef={(ref: any) => {
+ aceEditorRef.current = ref;
+ }}
Review Comment:
I saw this before as well, what's wrong with using useRef and ref here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
