jamra commented on code in PR #34802:
URL: https://github.com/apache/superset/pull/34802#discussion_r2294169114
##########
superset/models/sql_lab.py:
##########
@@ -80,10 +84,10 @@ class SqlTablesMixin: # pylint:
disable=too-few-public-methods
def sql_tables(self) -> list[Table]:
try:
return list(
- extract_tables_from_jinja_sql(
+ process_jinja_sql(
Review Comment:
<3 this approach. Process the Jinja then extract tables. Doesn't this also
need the template params though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
