mistercrunch commented on code in PR #34809:
URL: https://github.com/apache/superset/pull/34809#discussion_r2294549278
##########
superset-frontend/packages/superset-ui-core/src/components/Icons/AsyncIcon.tsx:
##########
@@ -46,6 +47,11 @@ const AsyncIcon = (props: IconType) => {
return (
<BaseIconComponent
component={ImportedSVG.current || TransparentIcon}
+ fileName={fileName}
+ customIcons={customIcons}
+ iconSize={iconSize}
+ iconColor={iconColor}
+ viewBox={viewBox}
{...restProps}
/>
Review Comment:
correct pattern but seems like a no-op to me since the same props would flow
through .`..restProps` before no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
