ethan-l-geotab commented on code in PR #33392:
URL: https://github.com/apache/superset/pull/33392#discussion_r2294746288
##########
superset-frontend/src/explore/components/PropertiesModal/index.tsx:
##########
@@ -179,20 +179,15 @@ function PropertiesModal({
}
try {
- const res = await SupersetClient.put({
+ let res = await SupersetClient.put({
endpoint: `/api/v1/chart/${slice.slice_id}`,
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(payload),
});
- // update the redux state
- const updatedChart = {
- ...payload,
- ...res.json.result,
- tags,
- id: slice.slice_id,
- owners: selectedOwners,
- };
- onSave(updatedChart);
+ res = await SupersetClient.get({
+ endpoint: `/api/v1/chart/${slice.slice_id}`,
+ });
+ onSave(res.json.result);
Review Comment:
Kinda.
put returns:
<img width="227" height="50" alt="image"
src="https://github.com/user-attachments/assets/10506a08-75a0-4d23-9451-254ed9f8c88c";
/>
get returns:
<img width="479" height="56" alt="image"
src="https://github.com/user-attachments/assets/a1580226-f331-4e28-bd20-95bc695a327c";
/>
I think cuz schema is int instead of relationship. I just am not sure if
theres other parts of the code that expects the owner list to be returned as a
list of ints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
