amaannawab923 commented on issue #33448: URL: https://github.com/apache/superset/issues/33448#issuecomment-3222605388
Hi @mistercrunch Sure i will complete the goals of hidePanels flag and using seperate flags , currently i am using a single flag isPortableExplore , i will split it into proper flags for config About the second point even I remember that historically Explore and Dashboard were implemented as two separate React apps with their own Redux stores, which made embedding Explore inside Dashboard quite challenging. But today, both Dashboard and Explore already share the same Redux store under the current SPA setup. This PR takes advantage of that single-store architecture — Explore is mounted directly inside the Dashboard using the shared store, which is what makes the embedded Explore work cleanly without duplicating state or introducing a parallel subsystem. In other words, we’re already aligned with the “single-store” approach you mentioned, and this implementation builds on top of that , Explore Just lives as an empty Reducer in Dashboard and i am just populating it and this felt more backwards compatible such that existing functionalities wont break -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
