mistercrunch commented on code in PR #34866:
URL: https://github.com/apache/superset/pull/34866#discussion_r2306081238


##########
superset-frontend/packages/superset-core/package.json:
##########
@@ -1,6 +1,6 @@
 {
   "name": "@apache-superset/core",
-  "version": "0.0.1-rc1",
+  "version": "0.0.1-rc2",

Review Comment:
   having some issues related to this. after running `npm i` I get this diff ->
   
   ```
   diff --git a/superset-frontend/package-lock.json 
b/superset-frontend/package-lock.json
   index 0f5538f1f4..1eda99b676 100644
   --- a/superset-frontend/package-lock.json
   +++ b/superset-frontend/package-lock.json
   @@ -53602,10 +53602,6 @@
            "kdbush": "^4.0.2"
          }
        },
   -    "node_modules/superset-core": {
   -      "resolved": "packages/superset-core",
   -      "link": true
   -    },
        "node_modules/supports-color": {
          "version": "7.2.0",
          "resolved": 
"https://registry.npmjs.org/supports-color/-/supports-color-7.2.0.tgz";,
   @@ -60600,7 +60596,8 @@
          }
        },
        "packages/superset-core": {
   -      "version": "0.0.1",
   +      "name": "@apache-superset/core",
   +      "version": "0.0.1-rc2",
          "license": "ISC",
          "devDependencies": {
            "@babel/cli": "^7.26.4",
   ```
   
   Not sure why but causes this error here 
https://github.com/apache/superset/actions/runs/17284322285/job/49058704481?pr=34876



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to