sadpandajoe opened a new pull request, #35074: URL: https://github.com/apache/superset/pull/35074
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR implements Phase 1 and Phase 2 of the Cypress to Playwright migration outlined in https://github.com/apache/superset/issues/SIP-178. It adds Playwright tests to GitHub Actions CI pipeline in shadow mode - running alongside existing Cypress tests without blocking PRs. Phase 1 completed: ✅ Local Playwright setup with 2/2 auth tests passing (14.2s execution) Phase 2 goal: Having tests run in CI in parallel with Cypress **Changes Made** 🔧 CI Infrastructure - New workflow: .github/workflows/superset-playwright.yml - Independent, non-required workflow - Shadow mode: continue-on-error: true allows validation without blocking PRs - Reuses infrastructure: Same PostgreSQL/Redis services and Flask setup as Cypress - Native parallelization: Uses Playwright's built-in workers (simpler than Python script) ⚙️ Build System Updates - bashlib functions: Added playwright-install() and playwright-run() - Environment config: playwright.config.ts now uses PLAYWRIGHT_BASE_URL for CI - Port coordination: Playwright uses port 8081 in CI (same as Cypress Flask server) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> **Local validation:** > cd superset-frontend > npx playwright test # 2/2 tests pass in 14.2s **CI validation:** - Push triggers new Playwright E2E Tests workflow - Runs auth tests against same infrastructure as Cypress - Collects artifacts on failure for debugging ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
