LevisNgigi commented on code in PR #33831: URL: https://github.com/apache/superset/pull/33831#discussion_r2344024573
########## superset-frontend/src/dashboard/components/GroupByBadge/index.tsx: ########## @@ -0,0 +1,362 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { memo, useMemo, useState, useRef } from 'react'; +import { useSelector } from 'react-redux'; +import { styled, t, useTheme } from '@superset-ui/core'; +import { Icons, Badge, Tooltip, Tag } from '@superset-ui/core/components'; +import { ClassNames } from '@emotion/react'; +import { getFilterValueForDisplay } from '../nativeFilters/utils'; +import { ChartCustomizationItem } from '../nativeFilters/ChartCustomization/types'; +import { RootState } from '../../types'; +import { isChartWithoutGroupBy } from '../../util/charts/chartTypeLimitations'; + +export interface GroupByBadgeProps { + chartId: number; +} + +const StyledTag = styled(Tag)` + ${({ theme }) => ` + display: flex; + align-items: center; + cursor: pointer; + margin-left: ${theme.sizeUnit * 2}px; + margin-right: ${theme.sizeUnit}px; + padding: ${theme.sizeUnit}px ${theme.sizeUnit * 2}px; + background: ${theme.colorBgContainer}; + border: 1px solid ${theme.colorBorder}; + border-radius: 4px; + height: 100%; + + .anticon { + vertical-align: middle; + color: ${theme.colorTextSecondary}; + margin-right: ${theme.sizeUnit}px; + &:hover { + color: ${theme.colorText}; + } + } + + &:hover { + background: ${theme.colorBgTextHover}; + } + + &:focus-visible { + outline: 2px solid ${theme.colorPrimary}; + } + `} +`; + +const StyledBadge = styled(Badge)` + ${({ theme }) => ` + margin-left: ${theme.sizeUnit}px; + &>sup.ant-badge-count { + padding: 0 ${theme.sizeUnit}px; + min-width: ${theme.sizeUnit * 4}px; + height: ${theme.sizeUnit * 4}px; + line-height: 1.5; + font-weight: ${theme.fontWeightStrong}; + font-size: ${theme.fontSizeSM - 1}px; + box-shadow: none; + padding: 0 ${theme.sizeUnit}px; + } + `} +`; + +const TooltipContent = styled.div` + ${({ theme }) => ` + min-width: 200px; + max-width: 300px; + overflow-x: hidden; + color: ${theme.colorText}; + font-size: ${theme.fontSizeSM}px; + `} +`; + +const SectionName = styled.span` + ${({ theme }) => ` + font-weight: ${theme.fontWeightStrong}; + font-size: ${theme.fontSizeSM}px; + `} +`; + +const GroupByInfo = styled.div` + ${({ theme }) => ` + margin-top: ${theme.sizeUnit}px; + &:not(:last-child) { + padding-bottom: ${theme.sizeUnit * 3}px; + } + `} +`; + +const GroupByItem = styled.div` + ${({ theme }) => ` + font-size: ${theme.fontSizeSM}px; + margin-bottom: ${theme.sizeUnit}px; + + &:last-child { + margin-bottom: 0; + } + `} +`; + +const GroupByName = styled.span` + ${({ theme }) => ` + padding-right: ${theme.sizeUnit}px; + font-style: italic; + `} +`; + +const GroupByValue = styled.span` + max-width: 100%; + flex-grow: 1; + overflow: auto; +`; + +export const GroupByBadge = ({ chartId }: GroupByBadgeProps) => { + const [tooltipVisible, setTooltipVisible] = useState(false); + const triggerRef = useRef<HTMLDivElement>(null); + const theme = useTheme(); + + const chartCustomizationItems = useSelector< + RootState, + ChartCustomizationItem[] + >( + ({ dashboardInfo }) => + dashboardInfo.metadata?.chart_customization_config || [], + ); + + const chartDataset = useSelector<RootState, string | null>(state => { + const chart = state.charts[chartId]; + if (!chart?.latestQueryFormData?.datasource) { + return null; + } + const chartDatasetParts = String( + chart.latestQueryFormData.datasource, + ).split('__'); + return chartDatasetParts[0]; + }); + + const applicableGroupBys = useMemo(() => { + if (!chartDataset) { + return []; + } + + return chartCustomizationItems.filter(item => { + if (item.removed) return false; + + const targetDataset = item.customization?.dataset; + if (!targetDataset) return false; + + const targetDatasetId = String(targetDataset); + const matchesDataset = chartDataset === targetDatasetId; + + const hasColumn = item.customization?.column; + + return matchesDataset && hasColumn; + }); + }, [chartCustomizationItems, chartDataset]); + + const chart = useSelector<RootState, any>(state => state.charts[chartId]); + const chartType = chart?.latestQueryFormData?.viz_type; + + const effectiveGroupBys = useMemo(() => { + if (!chartType || applicableGroupBys.length === 0) { + return []; + } + + if (isChartWithoutGroupBy(chartType)) { + return []; + } + + const chartFormData = chart?.latestQueryFormData; + if (!chartFormData) { + return applicableGroupBys; + } + + const existingColumns = new Set<string>(); + + const existingGroupBy = Array.isArray(chartFormData.groupby) + ? chartFormData.groupby + : chartFormData.groupby + ? [chartFormData.groupby] + : []; + existingGroupBy.forEach((col: string) => existingColumns.add(col)); + + if (chartFormData.x_axis) { + existingColumns.add(chartFormData.x_axis); + } + + const metrics = chartFormData.metrics || []; + metrics.forEach((metric: any) => { + if (typeof metric === 'string') { + existingColumns.add(metric); + } else if (metric && typeof metric === 'object' && 'column' in metric) { + const metricColumn = metric.column; + if (typeof metricColumn === 'string') { + existingColumns.add(metricColumn); + } else if ( + metricColumn && + typeof metricColumn === 'object' && + 'column_name' in metricColumn + ) { + existingColumns.add(metricColumn.column_name); + } + } + }); + + if (chartFormData.series) { + existingColumns.add(chartFormData.series); + } + if (chartFormData.entity) { + existingColumns.add(chartFormData.entity); + } + if (chartFormData.source) { + existingColumns.add(chartFormData.source); + } + if (chartFormData.target) { + existingColumns.add(chartFormData.target); + } Review Comment: okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
