Re: [PR] fix(loading): remove gap in horizontal filter bar and fix loading screen theming [superset]

Mon, 15 Sep 2025 09:26:36 -0700 


korbit-ai[bot] commented on code in PR #35125:
URL: https://github.com/apache/superset/pull/35125#discussion_r2345571805


##########
superset/templates/superset/spa.html:
##########
@@ -69,7 +69,7 @@
     {% endblock %}
   </head>
 
-  <body {% if standalone_mode %}class="standalone"{% endif %}>
+  <body {% if standalone_mode %}class="standalone"{% endif %} style="margin: 
0; padding: 0; background-color: {{ tokens.get('colorBgBase', '#ffffff') }};">

Review Comment:
   ### Inline Styles Violate Separation of Concerns <sub>![category 
Design](https://img.shields.io/badge/Design-0d9488)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Inline styles in the body tag mix styling concerns directly in the template 
structure.
   
   
   ###### Why this matters
   Mixing presentation logic directly in HTML structure makes the codebase 
harder to maintain and violates separation of concerns principles.
   
   ###### Suggested change ∙ *Feature Preview*
   Move styling to a dedicated CSS class:
   ```html
   <body class="{{ 'standalone' if standalone_mode }} base-theme">
   ```
   With corresponding CSS in a separate stylesheet.
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93a1804e-e3a2-4b98-ac2b-adeab1487caa/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93a1804e-e3a2-4b98-ac2b-adeab1487caa?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93a1804e-e3a2-4b98-ac2b-adeab1487caa?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93a1804e-e3a2-4b98-ac2b-adeab1487caa?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93a1804e-e3a2-4b98-ac2b-adeab1487caa)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:ec394bf6-50d0-4730-ba8f-546849fc6890 -->
   
   
   [](ec394bf6-50d0-4730-ba8f-546849fc6890)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to