sadpandajoe opened a new pull request, #35142: URL: https://github.com/apache/superset/pull/35142
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> - Fixed critical regression where legends disappeared in deck.gl Polygon charts between Superset 5.0 and 6.0 - Affected charts using linear_palette (default) and fixed_color schemes when displaying metrics - Single-line conditional logic fix with comprehensive test coverage **Root Cause** The bucket generation logic incorrectly treated any truthy colorSchemeType as requiring color breakpoints: before: ``` const buckets = colorSchemeType ? getColorBreakpointsBuckets(formData.color_breakpoints) : getBuckets(formData, payload.data.features, accessor); ``` after: ``` const buckets = colorSchemeType === COLOR_SCHEME_TYPES.color_breakpoints ? getColorBreakpointsBuckets(formData.color_breakpoints) : getBuckets(formData, payload.data.features, accessor); ``` When colorSchemeType was "linear_palette" or "fixed_color", it incorrectly called getColorBreakpointsBuckets() with undefined color_breakpoints, returning empty buckets and causing legends to disappear. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 11 comprehensive tests covering all scenarios: - Bucket generation logic for all color scheme types - Error handling and edge cases - Legend integration testing - Utility function validation Manual test: 1. open up a workspace 2. go to the polygon chart 3. verify legend shows up ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: fixes [#34822](https://github.com/apache/superset/issues/34822) - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
