eschutho opened a new pull request, #35146:
URL: https://github.com/apache/superset/pull/35146
## SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Adds comprehensive test coverage for the `sortMetric` functionality in the
`SelectFilterPlugin` component that was implemented in #<INSERT_PR_NUMBER>.
These tests ensure the fix for metric-based sorting works correctly across all
scenarios while maintaining backwards compatibility.
## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A - Test-only changes
## TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Run the test suite: `npm test -- SelectFilterPlugin.test.tsx`
2. Verify all 17 tests pass (including 4 new sortMetric tests)
3. Tests cover:
- Backend order preservation when `sortMetric` is specified
- Alphabetical sorting fallback when no `sortMetric` is specified
- Ascending and descending alphabetical sorting behavior
- `sortMetric` precedence over `sortAscending` setting
## ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [x] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
