VasilijeBursac commented on issue #34682: URL: https://github.com/apache/superset/issues/34682#issuecomment-3294177078
@mistercrunch @rusackas Sorry for the late response. I had to shift away from this for a while to focus on other tasks. The simplest approach I came up with for our needs was to modify the `Chart.tsx` component to call `renderChartContainer()` even during loading, overlaying the chart with the loading animation instead of replacing it. Specifically, I changed the following lines in` Chart.tsx` (specific lines are highlighted for easier navigation) https://github.com/apache/superset/blob/master/superset-frontend/src/components/Chart/Chart.tsx#L386-L388 to: ``` {this.renderChartContainer()} {isLoading && this.renderSpinner(databaseName)} ``` While I do agree that adding a light blur or opacity overlay on the chart might improve the visibility of the spinner, it would still preserve the core problem of noticeable flickering and distracting visual changes, just to a lesser extent. I’ve recorded a before-and-after comparison so you can see the difference and let me know what you think. Before: https://github.com/user-attachments/assets/861f6081-6f53-48ca-a4a0-f3e2f68a1e61 After: https://github.com/user-attachments/assets/d7d5f628-31a9-4c1c-a0b0-fe2a406c0341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
