eschutho commented on code in PR #35148: URL: https://github.com/apache/superset/pull/35148#discussion_r2350285877
########## LLMS.md: ########## @@ -136,6 +136,37 @@ curl -f http://localhost:8088/health || echo "❌ Setup required - see https://s - **Use negation operator**: `~Model.field` instead of `== False` to avoid ruff E712 errors - **Example**: `~Model.is_active` instead of `Model.is_active == False` +## Pull Request Guidelines + +**When creating pull requests, use the Superset PR template format:** + +```markdown +### SUMMARY +[Describe the change, including rationale and design decisions] + +### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF +[Skip if not applicable] + +### TESTING INSTRUCTIONS +[Required! What steps can be taken to manually verify the changes?] + +### ADDITIONAL INFORMATION +- [ ] Has associated issue: [Include "Fixes #nnn" if fixing an existing issue] +- [ ] Required feature flags: +- [ ] Changes UI +- [ ] Includes DB Migration (follow approval process in SIP-59) + - [ ] Migration is atomic, supports rollback & is backwards-compatible + - [ ] Confirm DB migration upgrade and downgrade tested + - [ ] Runtime estimates and downtime expectations provided +- [ ] Introduces new feature or API +- [ ] Removes existing feature or API +``` + +**PR Title Convention**: Follow [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) Review Comment: Although I suppose it can help get it right the first time rather than wait for CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
