giuliosmall commented on PR #35033: URL: https://github.com/apache/superset/pull/35033#issuecomment-3304309389
> Looks like pre-commit needs some love, too. > > Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following: > > ``` > pip3 install -r requirements/development.txt > pre-commit install > ``` > > A series of checks will now run when you make a git commit. > > Alternatively it is possible to run pre-commit by running pre-commit manually: > > ``` > pre-commit run --all-files > ``` Thanks @rusackas for taking the time to review my PR! I fixed all the linter complaints in c91f4e6 . ``` pre-commit run --all-files auto-walrus..............................................................Passed mypy (main)..............................................................Passed mypy (superset-extensions-cli)...........................................Passed check docstring is first.................................................Passed check for added large files..............................................Passed check yaml...............................................................Passed debug statements (python)................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed eslint (frontend)........................................................Passed eslint (docs)............................................................Passed Type-Checking (Frontend).................................................Passed Blacklist................................................................Passed Helm Docs................................................................Passed ruff-format..............................................................Passed ruff.....................................................................Passed pylint with custom Superset plugins......................................Passed ``` And tests are passing as well ``` npm test -- plugins/legacy-preset-chart-deckgl/src/utils.test.ts > [email protected] test > cross-env NODE_ENV=test NODE_OPTIONS="--max-old-space-size=8192" jest --max-workers=80% --silent plugins/legacy-preset-chart-deckgl/src/utils.test.ts jest-haste-map: duplicate manual mock found: mockExportObject The following files share their name; please delete one of them: * <rootDir>/spec/__mocks__/mockExportObject.js * <rootDir>/packages/superset-ui-core/__mocks__/mockExportObject.js jest-haste-map: duplicate manual mock found: mockExportString The following files share their name; please delete one of them: * <rootDir>/spec/__mocks__/mockExportString.js * <rootDir>/packages/superset-ui-core/__mocks__/mockExportString.js jest-haste-map: duplicate manual mock found: svgrMock The following files share their name; please delete one of them: * <rootDir>/spec/__mocks__/svgrMock.tsx * <rootDir>/packages/superset-ui-core/__mocks__/svgrMock.tsx PASS plugins/legacy-preset-chart-deckgl/src/utils.test.ts Test Suites: 1 passed, 1 total Tests: 24 passed, 24 total Snapshots: 0 total Time: 3.957 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
