mistercrunch commented on code in PR #35179:
URL: https://github.com/apache/superset/pull/35179#discussion_r2357432753
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -582,9 +582,21 @@ export default function transformProps(
richTooltip,
tooltipSortByMetric,
);
+ const filteredForecastValue = forecastValue.filter(
+ (item: any) =>
+ !annotationLayers.some(
+ (annotation: any) => item.seriesName === annotation.name,
+ ),
+ );
const forecastValues: Record<string, ForecastValue> =
extractForecastValuesFromTooltipParams(forecastValue, isHorizontal);
+ const filteredForecastValues: Record<string, ForecastValue> =
Review Comment:
No biggy but I was surprised to see types re-stated here, looked up the
function definition and types are defined there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
