sfirke commented on code in PR #35185: URL: https://github.com/apache/superset/pull/35185#discussion_r2361251606
########## docs/docs/configuration/alerts-reports.mdx: ########## @@ -36,11 +36,11 @@ Screenshots will be taken but no messages actually sent as long as `ALERT_REPORT #### In your `Dockerfile` You'll need to extend the Superset image to include a headless browser. Your options include: -- Use Playwright with Chrome: this is the recommended approach as of version >=4.1.x. A working example of a Dockerfile that installs these tools is provided under “Building your own production Docker image” on the [Docker Builds](/docs/installation/docker-builds#building-your-own-production-docker-image) page. Read the code comments there as you'll also need to change a feature flag in your config. +- Use Playwright with Chrome: this is the recommended approach as of version `>=4.1.x`. A working example of a Dockerfile that installs these tools is provided under "Building your own production Docker image" on the [Docker Builds](/docs/installation/docker-builds#building-your-own-production-docker-image) page. Read the code comments there as you'll also need to change a feature flag in your config. - Use Firefox: you'll need to install geckodriver and Firefox. - Use Chrome without Playwright: you'll need to install Chrome and set the value of `WEBDRIVER_TYPE` to `"chrome"` in your `superset_config.py`. -In Superset versions <=4.0x, users installed Firefox or Chrome and that was documented here. +In Superset versions `<=4.0.x`, users installed Firefox or Chrome and that was documented here. Review Comment: This one could be "prior to 4.1" - it should include 4.0.x to be accurate. ```suggestion In Superset versions prior to 4.1, users installed Firefox or Chrome and that was documented here. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
