dpgaspar opened a new pull request, #33055: URL: https://github.com/apache/superset/pull/33055
## Summary This PR upgrades Flask-AppBuilder from 4.5.1 to 5.0.0, unlocking the path for Superset to adopt SQLAlchemy 2.x and Flask 3.x. While this upgrade alone doesn't enable these newer versions (additional Superset changes will be required), Flask-AppBuilder is no longer a blocker for these critical upgrades. ## Key Changes - Upgraded Flask-AppBuilder to 5.0.0 - Updated dependencies to support FAB 5.x requirements - Modified code to comply with FAB 5.0.0 breaking changes ## Breaking Changes Please review the Flask-AppBuilder migration guides: - [FAB 5.0.0 Migration Guide](https://flask-appbuilder.readthedocs.io/en/latest/versionmigration.html#migrating-to-5-0-0) - [FAB 5.0.0 PR with detailed changes](https://github.com/dpgaspar/Flask-AppBuilder/pull/2241) ## Performance Impact Performance testing shows a slight improvement of approximately **~2%** in API response times: - Tested with 200 requests each to `/api/v1/chart`, `/api/v1/dataset`, and `/api/v1/dashboard` - Overall average response time improved from 80.78ms to 78.61ms ## Future Work This PR sets the foundation for: - **SQLAlchemy 2.x support**: I will submit follow-up PRs to enable SQLAlchemy 2.x compatibility - **Flask 3.x support**: Additional PRs will address Flask 3.x compatibility requirements Note: While this PR makes FAB 5.0.0 compatible, actual migration to SQLAlchemy 2.x and Flask 3.x will require additional changes to Superset's codebase, which will be addressed in separate PRs. ## Testing Instructions - All existing tests pass - API performance validated - No regressions in core functionality ## UPDATING.md - [ ] Add entry documenting this upgrade for users --- This upgrade is a critical step in modernizing Superset's dependency stack and ensuring long-term maintainability with current Python ecosystem standards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
