Copilot commented on code in PR #35198:
URL: https://github.com/apache/superset/pull/35198#discussion_r2361288297
##########
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx:
##########
@@ -368,9 +368,13 @@ const CustomModal = ({
};
CustomModal.displayName = 'Modal';
+// Theme-aware confirmation modal - now inherits theme through App wrapper in
SupersetThemeProvider
Review Comment:
[nitpick] The `themedConfirm` function is a simple passthrough that doesn't
add any theming logic. Consider adding a comment explaining that the actual
theming is handled by the App wrapper in SupersetThemeProvider, or remove this
wrapper if it's not adding value beyond documentation.
```suggestion
// The themedConfirm function is a simple passthrough to AntdModal.confirm.
// Actual theming is handled by the App wrapper in SupersetThemeProvider.
// This wrapper exists only for documentation and API consistency.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
