eschutho opened a new pull request, #35201:
URL: https://github.com/apache/superset/pull/35201

   ## SUMMARY
   Hide the favorite column in chart and dashboard list views when none of the 
items on the current page have been marked as favorites. This improves the UI 
by removing empty, non-functional columns that provide no value to users.
   
   The implementation adds a memoized helper that checks if any items on the 
page are favorited, and conditionally hides the favorite column when no 
favorites exist.
   
   ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before**: Empty favorite column shows when user is logged in but no items 
are favorited
   **After**: Favorite column is completely hidden when no items on the page 
have favorites
   
   ## TESTING INSTRUCTIONS
   1. Start the development environment
   2. Navigate to Charts page (`/chart/list/`)
   3. Ensure you're logged in as a user with chart access
   4. Verify that when no charts are marked as favorites, the favorite column 
is hidden
   5. Add at least one chart to favorites and verify the column appears
   6. Test the same behavior on the Dashboards page (`/dashboard/list/`)
   
   ## ADDITIONAL INFORMATION
   - [x] Changes UI
   - [x] Has been tested locally
   - [x] No breaking changes
   - [x] Follows existing code patterns
   
   🤖 Generated with [Claude Code](https://claude.ai/code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to