msyavuz commented on code in PR #34276:
URL: https://github.com/apache/superset/pull/34276#discussion_r2349977189
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -149,9 +149,35 @@ const Styles = styled.div`
}
.tab-content {
- overflow: auto;
+ overflow: visible;
flex: 1 1 100%;
}
+
+ // Ensure Ant Design tabs allow content to expand
+ .ant-tabs-content {
+ overflow: visible !important;
+ height: auto !important;
+ }
+
+ .ant-tabs-content-holder {
+ overflow: visible !important;
+ height: auto !important;
+ }
+
+ .ant-tabs-tabpane {
+ overflow: visible !important;
+ height: auto !important;
+ }
+
+ // Ensure collapse components can expand
+ .ant-collapse-content {
+ overflow: visible !important;
+ }
+
+ .ant-collapse-content-box {
+ overflow: visible !important;
+ }
Review Comment:
Do we need these `!important`?
##########
superset/viz.py:
##########
@@ -2049,8 +2206,7 @@ def get_properties(self, data: dict[str, Any]) ->
dict[str, Any]:
if self.form_data.get("reverse_long_lat"):
path = [(o[1], o[0]) for o in path]
data[self.deck_viz_key] = path
- if line_type != "geohash":
- del data[line_column]
+ # Do not delete the original line_column (e.g., path_json), keep it
for tooltips
Review Comment:
```suggestion
```
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Screengrid/Screengrid.tsx:
##########
@@ -32,14 +36,29 @@ import { commonLayerProps, getColorRange } from '../common';
import TooltipRow from '../../TooltipRow';
import { GetLayerType, createDeckGLComponent } from '../../factory';
import { HIGHLIGHT_COLOR_ARRAY, TRANSPARENT_COLOR_ARRAY } from '../../utils';
+import {
+ createTooltipContent,
+ CommonTooltipRows,
+} from '../../utilities/tooltipUtils';
+
+const MoreRecordsIndicator = styled.div`
+ margin-top: 4px;
+ font-size: 12px;
Review Comment:
Should these be theme variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
