aminghadersohi commented on code in PR #35063:
URL: https://github.com/apache/superset/pull/35063#discussion_r2369846956
##########
superset/utils/webdriver.py:
##########
@@ -87,8 +146,8 @@ class WebDriverProxy(ABC):
def __init__(self, driver_type: str, window: WindowSize | None = None):
self._driver_type = driver_type
self._window: WindowSize = window or (800, 600)
- self._screenshot_locate_wait = app.config["SCREENSHOT_LOCATE_WAIT"]
- self._screenshot_load_wait = app.config["SCREENSHOT_LOAD_WAIT"]
+ self._screenshot_locate_wait =
app.config.get("SCREENSHOT_LOCATE_WAIT", 10)
+ self._screenshot_load_wait = app.config.get("SCREENSHOT_LOAD_WAIT", 60)
Review Comment:
Ah. yeah, Thanks. Good catch! Since the defaults are configured in
config.py, switched to strict app.config["KEY"].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
