mistercrunch commented on code in PR #35240:
URL: https://github.com/apache/superset/pull/35240#discussion_r2373297277
##########
superset-frontend/webpack.config.js:
##########
@@ -184,21 +184,64 @@ if (!isDevMode) {
chunkFilename: '[name].[chunkhash].chunk.css',
}),
);
+}
- // Runs type checking on a separate process to speed up the build
+// Type checking for both dev and production
+// In dev mode, this provides real-time type checking and builds .d.ts files
for plugins
+// Can be disabled with DISABLE_TYPE_CHECK=true npm run dev
+if (isDevMode) {
+ if (process.env.DISABLE_TYPE_CHECK) {
+ console.log('⚡ Type checking disabled (DISABLE_TYPE_CHECK=true)');
+ } else {
+ console.log(
+ '✅ Type checking enabled (disable with DISABLE_TYPE_CHECK=true npm run
dev)',
+ );
+ // Optimized configuration for development - much faster type checking
+ plugins.push(
+ new ForkTsCheckerWebpackPlugin({
+ typescript: {
+ memoryLimit: 8192,
Review Comment:
Oh right, other places in the file we use 4096, maybe i'll stick to that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
