gabotorresruiz opened a new pull request, #35254: URL: https://github.com/apache/superset/pull/35254
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Adds an unsaved changes confirmation modal to the Theme Editor to prevent accidental data loss when users have made modifications but haven't saved them. When closing the modal with unsaved changes, users are prompted with options to save, discard, or continue editing. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable -->  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Navigate to Settings > Themes 2. Click "Add Theme" or edit an existing theme 3. Make changes to the theme name or JSON configuration 4. Click Cancel or the X button to close the modal 5. Verify that the unsaved changes modal appears with three options: - "Keep editing" - returns to the editor - "Save and close" - saves changes and closes - "Discard changes" - closes without saving 6. Test that the modal does NOT appear when: - No changes have been made - Viewing a read-only system theme - After successfully saving changes ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
