gabotorresruiz commented on code in PR #35220:
URL: https://github.com/apache/superset/pull/35220#discussion_r2375839747
##########
superset-frontend/packages/superset-ui-core/src/components/Typography/Typography.test.tsx:
##########
@@ -50,7 +50,7 @@ describe('Typography Component', () => {
it('renders strong text', () => {
render(<Typography.Text strong>Strong Text</Typography.Text>);
- expect(screen.getByText('Strong Text')).toHaveStyle('font-weight: 500');
+ expect(screen.getByText('Strong Text')).toHaveStyle('font-weight: 600');
Review Comment:
The test changed because `fontWeightStrong: 500` theme token was moved from
the frontend (Theme.tsx) to the backend (config.py). During unit tests, the
backend config isn't available, so Ant Design's default (600) is used instead.
The test now reflects this fallback behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
