Antonio-RiveroMartnez commented on code in PR #35213:
URL: https://github.com/apache/superset/pull/35213#discussion_r2378777851
##########
superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx:
##########
@@ -39,98 +37,83 @@ const TABS_KEYS = {
LAYOUT_ELEMENTS: 'LAYOUT_ELEMENTS',
};
-const BuilderComponentPane = ({ topOffset = 0 }) => {
- const theme = useTheme();
- const nativeFiltersBarOpen = useSelector(
- (state: any) => state.dashboardState.nativeFiltersBarOpen ?? false,
- );
-
- const tabBarStyle = useMemo(
- () => ({
- paddingLeft: nativeFiltersBarOpen ? 0 : theme.sizeUnit * 4,
- }),
- [nativeFiltersBarOpen, theme.sizeUnit],
- );
-
- return (
+const BuilderComponentPane = ({ topOffset = 0 }) => (
+ <div
+ data-test="dashboard-builder-sidepane"
+ css={css`
+ position: sticky;
+ right: 0;
+ top: ${topOffset}px;
+ height: calc(100vh - ${topOffset}px);
+ width: ${BUILDER_PANE_WIDTH}px;
+ `}
+ >
<div
- data-test="dashboard-builder-sidepane"
- css={css`
- position: sticky;
- right: 0;
- top: ${topOffset}px;
- height: calc(100vh - ${topOffset}px);
+ css={(theme: SupersetTheme) => css`
+ position: absolute;
+ height: 100%;
width: ${BUILDER_PANE_WIDTH}px;
+ box-shadow: -4px 0 4px 0
Review Comment:
nit: Can you use the theme units here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
