dosubot[bot] commented on issue #35236: URL: https://github.com/apache/superset/issues/35236#issuecomment-3322651115
<!-- Answer --> You're correct—the CloseButton in ConditionalFormattingControl.tsx does not have a background property set. Its visibility in dark themes depends entirely on the background behind it, which can make the CloseOutlined icon hard to see or invisible in dark mode. Adding a background (such as the gradient you suggested) to the CloseButton would likely resolve the visibility issue and improve accessibility in dark themes. You can see the current style definition here for reference: [source](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/a0f7473c-fbbf-4479-9e7d-51a998cc72d5?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/35236) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
