GitHub user dosubot[bot] added a comment to the discussion: Why doesn't Doris 
support quarter aggregation?

<!-- Answer -->
The code you need to modify is in superset/db_engine_specs/doris.py, inside the 
DorisEngineSpec class. To fix quarter aggregation, override the 
_time_grain_expressions dictionary in DorisEngineSpec and provide a 
Doris-compatible SQL expression for TimeGrain.QUARTER. For example, if Doris 
supports QUARTER() and YEAR(), you could use something like:

```python
from superset.db_engine_specs.base import TimeGrain

_time_grain_expressions = {
    **MySQLEngineSpec._time_grain_expressions,
    TimeGrain.QUARTER: "CONCAT(YEAR({col}), '-Q', QUARTER({col}))",
}
```

This approach is similar to how other engines (like Impala) define custom time 
grains in their engine spec files 
([reference](https://github.com/apache/superset/issues/33033)). The key is to 
override the inherited MySQL quarter logic, which Doris does not support, with 
an expression that works for Doris.


<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*

---
<sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/1aa96df4-9dce-4cd6-869d-6e50d15e885f?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat
 with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)&
 nbsp;[![Join 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share
 on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/discussions/35304)

GitHub link: 
https://github.com/apache/superset/discussions/35304#discussioncomment-14519937

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: 
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to