eschutho commented on code in PR #35294:
URL: https://github.com/apache/superset/pull/35294#discussion_r2383515253
##########
pyproject.toml:
##########
@@ -133,7 +133,7 @@ denodo = ["denodo-sqlalchemy~=1.0.6"]
dremio = ["sqlalchemy-dremio>=1.2.1, <4"]
drill = ["sqlalchemy-drill>=1.1.4, <2"]
druid = ["pydruid>=0.6.5,<0.7"]
-duckdb = ["duckdb-engine>=0.17.0"]
+duckdb = ["duckdb>=0.10.2,<0.11", "duckdb-engine>=0.12.1,<0.13"]
Review Comment:
latest change from Claude:
│ Testing confirmed that duckdb-engine>=0.17.0 works correctly with
│
│ duckdb 0.10.2. The issue is only with newer duckdb versions (1.3.x),
│
│ not with the SQLAlchemy driver.
│
│
│
│ This more targeted fix:
│
│ - Constrains duckdb to >=0.10.2,<0.11 (avoids 1.3.x compatibility
issues)
│
│ - Keeps duckdb-engine at >=0.17.0 (current version, works fine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
