LevisNgigi commented on issue #35158: URL: https://github.com/apache/superset/issues/35158#issuecomment-3341406895
> I'm late to the party, but I have some questions before I cast my vote :) > > 1. In the "Chart Customization" modal, do we expect to carry over other things BESIDE the "groupby" options? > 2. Does the term "Chart Customization" sound like it's customizing the chart? Might be confusing - we already have the Chart Properties modal for that. > 3. Is there any reason not to change "Add or edit filters" to be "Manage filters and groupings" and just add this into the filter modal (to be renamed) alongside scoping as a new tab OR just let it live in the list of other filters? It kind of makes sense to me to have filters and group-bys managed in the same spot, especially when the UI is strikingly similar. > 4. If this IS going to be a modal of its own, Just wondering what the code footprint is here... hopefully it can be pretty DRY/minimal and recycle existing stuff. @rusackas > 1. Per the Figma designs there may eventually be additional dashboard-level chart-altering options, but for now dynamic group-by is the only feature in this modal. > 2. The “Chart Customization” label came from the Figma spec. I agree we can revisit it with product/UX if it feels too close to “Chart Properties.” The intent was “let the user adjust how the chart is presented,” which is why “customization” was chosen. >3. Yes that is a great point, there was discussion about folding this into the Filters modal. It was preferred to have a new modal because future chart-altering features are expected, I think. >4. I reused a number of components, styling, and layout from the Filters modal to stay DRY. The PR is a bit larger because the group-by logic is distinct even though the UI looks similar.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
