geido commented on code in PR #35336:
URL: https://github.com/apache/superset/pull/35336#discussion_r2394838728
##########
superset-frontend/src/dashboard/components/gridComponents/Markdown/Markdown.jsx:
##########
@@ -268,6 +269,13 @@ class Markdown extends PureComponent {
}
}
+ shouldFocusMarkdown(event, container) {
+ if (container?.contains(event.target)) return true;
+ if (event.target.closest?.('.menu-item')) return true;
Review Comment:
Not too sure about this check? Is this a class name that we control? I have
found a few unrelated references in the codebase. Maybe there is an opportunity
to improve the name or the target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
