geido commented on code in PR #35338:
URL: https://github.com/apache/superset/pull/35338#discussion_r2394907550
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/hooks/useSticky.tsx:
##########
@@ -221,6 +224,26 @@ function StickyWrap({
let footerTable: ReactElement | undefined;
let bodyTable: ReactElement | undefined;
+ const scrollBarStyles = css`
+ &::-webkit-scrollbar {
+ width: 8px;
+ height: 8px;
+ }
+ &::-webkit-scrollbar-track {
+ background: ${theme.colorFillQuaternary};
+ }
+ &::-webkit-scrollbar-thumb {
+ background: ${theme.colorFillSecondary};
+ border-radius: 4px;
Review Comment:
Can we use the theme provided border radius here?
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/PivotTableChart.tsx:
##########
@@ -55,9 +55,38 @@ const Styles = styled.div<PivotTableStylesProps>`
`;
const PivotTableWrapper = styled.div`
- height: 100%;
- max-width: inherit;
- overflow: auto;
+ ${({ theme }) => `
+ height: 100%;
+ max-width: inherit;
+ overflow: auto;
+
+ /* Chrome/Safari/Edge webkit scrollbar styling */
+ &::-webkit-scrollbar {
+ width: ${theme.sizeUnit * 2}px;
+ height: ${theme.sizeUnit * 2}px;
Review Comment:
I think we should not be using `sizeUnit` for widths and heights but only
for spacing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
