bito-code-review[bot] commented on code in PR #35436:
URL: https://github.com/apache/superset/pull/35436#discussion_r2396018942
##########
docs/yarn.lock:
##########
@@ -2016,6 +2163,22 @@
webpack "^5.95.0"
webpack-merge "^5.9.0"
+"@docusaurus/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Docusaurus version conflict</b></div>
<div id="fix">
The PR adds Docusaurus 3.9.1 packages (`@docusaurus/[email protected]`,
`@docusaurus/[email protected]`, `@docusaurus/[email protected]`, and
`@docusaurus/[email protected]`) while keeping 3.8.1 versions in the lockfile. This
creates version conflicts where packages like `@docusaurus/[email protected]`
depends on `@docusaurus/[email protected]` but the new
`@docusaurus/[email protected]` depends on `@docusaurus/[email protected]`. This
will cause runtime errors and build failures due to incompatible type
definitions and dependency resolution issues. Update package.json to use
consistent Docusaurus versions across all packages.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/docs/package.json
+++ b/docs/package.json
@@ -31,8 +31,8 @@
"dependencies": {
"@ant-design/icons": "^6.0.0",
- "@docusaurus/core": "3.8.1",
+ "@docusaurus/core": "3.9.1",
"@docusaurus/plugin-client-redirects": "3.9.1",
- "@docusaurus/preset-classic": "3.8.1",
- "@docusaurus/theme-mermaid": "^3.8.1",
+ "@docusaurus/preset-classic": "3.9.1",
+ "@docusaurus/theme-mermaid": "^3.9.1",
"@emotion/core": "^10.0.27",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35436#issuecomment-3358301345>#2540ef</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -1722,16 +1869,16 @@
react-helmet-async "npm:@slorber/[email protected]"
react-loadable "npm:@docusaurus/[email protected]"
-"@docusaurus/[email protected]":
- version "3.8.1"
- resolved
"https://registry.yarnpkg.com/@docusaurus/plugin-client-redirects/-/plugin-client-redirects-3.8.1.tgz#1d02b3565ae4e53a3b8005835501f07fb0bc0267";
- integrity
sha512-F+86R7PBn6VNgy/Ux8w3ZRypJGJEzksbejQKlbTC8u6uhBUhfdXWkDp6qdOisIoW0buY5nLqucvZt1zNJzhJhA==
+"@docusaurus/[email protected]":
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Docusaurus version mismatch</b></div>
<div id="fix">
The yarn.lock shows @docusaurus/plugin-client-redirects being upgraded to
3.9.1, but the package.json still specifies 3.8.1 for @docusaurus/core and
other packages. This creates a version mismatch that will cause runtime errors.
Update package.json to use consistent Docusaurus 3.9.1 versions across all
@docusaurus packages to prevent dependency conflicts.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/docs/package.json
+++ b/docs/package.json
@@ -31,3 +31,3 @@
- "@docusaurus/core": "3.8.1",
+ "@docusaurus/core": "3.9.1",
"@docusaurus/plugin-client-redirects": "3.9.1",
- "@docusaurus/preset-classic": "3.8.1",
+ "@docusaurus/preset-classic": "3.9.1",
- "@docusaurus/theme-mermaid": "^3.8.1",
+ "@docusaurus/theme-mermaid": "^3.9.1",
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35436#issuecomment-3358301345>#2540ef</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
