bito-code-review[bot] commented on code in PR #35453:
URL: https://github.com/apache/superset/pull/35453#discussion_r2399381797
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx:
##########
@@ -131,10 +131,7 @@ const AgGridDataTable: FunctionComponent<AgGridTableProps>
= memo(
const defaultColDef = useMemo<ColDef>(
() => ({
- flex: 1,
filter: true,
- enableRowGroup: true,
- enableValue: true,
sortable: true,
resizable: true,
minWidth: 100,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing AG Grid properties</b></div>
<div id="fix">
The removal of `flex: 1`, `enableRowGroup: true`, and `enableValue: true`
from `defaultColDef` will break core AG Grid functionality. These properties
are essential for responsive column sizing (`flex: 1`), enabling users to group
rows by dragging columns (`enableRowGroup: true`), and allowing value
aggregation for metrics (`enableValue: true`). Without these, the table will
have fixed-width columns and users will lose the ability to group data or
perform aggregations through the UI. Restore these properties to maintain
expected table behavior.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```suggestion
flex: 1,
filter: true,
sortable: true,
enableRowGroup: true,
resizable: true,
enableValue: true,
minWidth: 100,
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/35453#issuecomment-3362059832>#d4eefe</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
