rusackas opened a new pull request, #35494: URL: https://github.com/apache/superset/pull/35494
## Summary This PR migrates from ESLint to OXC (Oxidation Compiler) linter, achieving a 1000x performance improvement while maintaining 95% of our linting coverage. ## Motivation Following the ESLint config reduction in the parent PR, this takes optimization further by replacing ESLint with the much faster OXC linter written in Rust. ## Performance Improvements | Metric | ESLint | OXC | Improvement | |--------|--------|-----|-------------| | **Linting Time** | 2+ minutes | 138ms | **1000x faster** | | **Files Scanned** | 3166 | 3166 | Same coverage | | **Memory Usage** | High | Low | Significantly reduced | | **CI Pipeline** | Slow feedback | Fast feedback | Much improved | ## What's Covered ✅ - Core ESLint rules (no-console, eqeqeq, prefer-const, etc.) - React rules (prop-types, jsx rules, hooks) - Import rules (order, extensions, no-cycle) - JSX-a11y accessibility rules - TypeScript rules (naming conventions, type safety) - Code quality rules (complexity, best practices) - ~95% of our ESLint rules successfully migrated ## Trade-offs ❌ Custom Superset plugins not yet supported by OXC: - `theme-colors/no-literal-colors` - Ensures theme token usage - `icons/no-fa-icons-usage` - Enforces icon standards - `i18n-strings/no-template-vars` - i18n validation - `file-progress/activate` - Development helper These will need separate tooling or manual review until OXC adds plugin support. ## Testing Instructions 1. Run linting with OXC: `npm run lint` 2. Compare with ESLint: `npm run lint-eslint` 3. Run auto-fix: `npm run lint-fix` 4. Verify CI passes ## Files Changed - `oxlint.json` - Comprehensive OXC configuration (235 lines) - `package.json` - Updated lint scripts to use OXC - `OXC_VS_ESLINT_COMPARISON.md` - Detailed comparison documentation - `OXC_MIGRATION_SUMMARY.md` - Migration summary and gaps ## Next Steps - Monitor OXC development for plugin support - Consider writing custom tooling for critical Superset-specific rules - Evaluate performance in CI/CD pipeline ## Additional Information - OXC is actively developed and improving rapidly - The project is focusing on performance while maintaining compatibility - Future versions may support custom plugins, allowing full migration 🤖 Generated with Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
