eschutho opened a new pull request, #35501: URL: https://github.com/apache/superset/pull/35501
### SUMMARY Refactors modal test files to follow the "avoid nesting when testing" pattern by removing nested `describe()/it()` blocks in favor of flat `test()` calls. **Changes:** - Flatten test structure in `EmbeddedModal.test.tsx` - remove nested describe blocks, use top-level `test()` calls - Flatten test structure in `ThemeList.test.tsx` - remove nested describe blocks, use top-level `test()` calls - Improve test readability and maintainability following Kent C. Dodds' testing principles **Benefits:** - Clearer test isolation and independence - Easier to scan and understand test suite - Follows modern React Testing Library best practices - Aligns with Superset's ongoing testing strategy migration ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - Test structure refactoring only, no functional changes ### TESTING INSTRUCTIONS ```bash npm test -- ThemeList.test.tsx --testPathIgnorePatterns=cypress npm test -- EmbeddedModal.test.tsx --testPathIgnorePatterns=cypress ``` Both test suites should pass with all tests (13 tests for ThemeList, 14 tests for EmbeddedModal). ### ADDITIONAL INFORMATION - [x] Changes follow "avoid nesting when testing" principles from CLAUDE.md - [x] All existing tests pass without modification to assertions - [x] No functional changes to test coverage or behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
