Bunbunw commented on issue #21870: URL: https://github.com/apache/superset/issues/21870#issuecomment-3395484552
Hi everyone, I am together with CoolDude937. We tried to figure out why an extra “null” month that is outside of the selected time range is displayed. We suspect that this issue is occurring due to fixed timezone offset variable stdTimezoneOffset in superset-frontend/plugins/legacy-plugin-chart-calendar/src/vendor/cal-heatmap.js, which shifts all timestamps by a fixed value without the consideration of the user's browser timezone offset and DST (Daylight Saving Time) together correctly. E.g. if your timezone is EST, then its UTC-05:00, because of summer daylight saving time in north america, we have UTC-04:00, which matches our observation where if it's after 4am of the first day of the month, the rendering is correct. Our intended solution would be to fix the current timezone offset by making sure that the correct value is added to each timestamp with consideration of timezone differences and DST, that way it's minimal and doesn't touch other components. We would also fix more problems related to calendar heatmap if we are done with this issue. We would like to ask for any feedback or advice regarding our intended solution if possible, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
