rebenitez1802 commented on PR #35349: URL: https://github.com/apache/superset/pull/35349#issuecomment-3399593812
@gabotorresruiz Thank you for the thoughtful feedback! You're absolutely right about the maintenance concerns and forward compatibility issues. I'd like to refactor to a simpler approach that addresses your concerns while keeping the most valuable part: **catching token name typos**. I would like to keep token validations as a soft validation, Instead of manually maintaining validators, we'll extract valid token names at runtime from `theme.getDesignToken()` and combine them with Superset's custom tokens. This gives us: - ✅ Zero maintenance (auto-syncs with installed Ant Design version) - ✅ Forward compatible (new tokens automatically work) - ✅ Catches typos (e.g., `colrPrimary` → warning) - ✅ Non-blocking (warnings don't prevent saves) Your point about Ant Design being "permissive and forward compatible" is spot-on. Instead of reimplementing their validation, we embrace it. We only warn about likely typos, and let Ant Design handle value validation as designed. ### User Experience - Valid tokens → no annotation - Unknown tokens → yellow warning (can still save) - Empty theme → red error (blocks save) - Invalid values → Ant Design handles at runtime Does this simplified approach address your concerns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
