sadpandajoe opened a new pull request, #35590:
URL: https://github.com/apache/superset/pull/35590
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Removes 3 duplicate JSX test files that have TypeScript counterparts already
in the codebase. This cleanup aligns with the frontend modernization effort to
eliminate JavaScript files.
Files removed:
1. ListView.test.jsx - All tests merged into existing ListView.test.tsx
(now 9 tests total)
2. DatasourceControl.test.jsx - Duplicate of comprehensive
DatasourceControl.test.tsx (21 tests)
3. VizTypeControl.test.jsx - Duplicate of comprehensive
VizTypeControl.test.tsx (10 tests)
Impact:
- 4 files changed, 259 insertions(+), 575 deletions(-)
- Net reduction: 316 lines
- All 40 tests passing ✅
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Verify all migrated tests pass:
npm run test -- src/components/ListView/ListView.test.tsx
npm run test --
src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
npm run test --
src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
