michael-s-molina commented on issue #35498: URL: https://github.com/apache/superset/issues/35498#issuecomment-3398556612
I was also one of the pre-reviewers of this SIP and left many comments to the original version which were fully addressed by @aminghadersohi. The main points were to make sure the work is compatible with the Extensions work through the dependency on the core packages and that the logic implemented by commands and DAOs were fully reused, especially the security rules. Thank you so much @aminghadersohi for writing this SIP and patiently addressing all comments during the pre-review phase. Your contribution is a wonderful addition to the Superset project! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
