michael-s-molina commented on code in PR #35308:
URL: https://github.com/apache/superset/pull/35308#discussion_r2411575600
##########
superset-frontend/packages/superset-core/package.json:
##########
@@ -10,6 +10,15 @@
],
"author": "",
"license": "ISC",
+ "dependencies": {
+ "@emotion/cache": "^11.4.0",
Review Comment:
Shouldn't these be peer dependencies?
##########
superset-frontend/src/components/Datasource/ChangeDatasourceModal/index.tsx:
##########
@@ -285,7 +285,6 @@ const ChangeDatasourceModal:
FunctionComponent<ChangeDatasourceModalProps> = ({
{!confirmChange && (
<>
<Alert
- roomBelow
Review Comment:
Is this change intended?
##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -26,7 +26,7 @@ import {
ThemeMode,
themeObject as supersetThemeObject,
} from '@superset-ui/core';
-import { normalizeThemeConfig } from '@superset-ui/core/theme/utils';
+import { normalizeThemeConfig } from '@apache-superset/core/ui/theme';
Review Comment:
It seems this function could be exported from `@apache-superset/core/ui` as
it seems generic enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
