fin-gal commented on issue #34621: URL: https://github.com/apache/superset/issues/34621#issuecomment-3385135574
@JoshuaJADaniel To me the label option and property name seems great. For the properties, here I'm not an expert nor do i have extensive knowledge of the superset code base and conventions but I see a few approaches: 1. We expose them to the user through checkboxes, buttons, etc... As is done for the line settings: filled, stroked, width, etc... I assume this method by default would apply these settings to all points globally, I can't think of an easy way to assign them to specific points through the UI? 2. Or they get taken in programmatically, here is where it gets more blurry for me: - One way could be to take in some kind of JSON from the user, I think this is not very standard in superset? - Or we get the properties from the user's data. For example, there's this `Extra data for JS` field in the Advanced part that allows to add columns. The sharedDeckGL component seems [to pick these columns up](https://github.com/apache/superset/blob/ed47ceb1e4271154f468d21acd12dbfe768abd4f/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx#L163) and store them as `jsColumns`. The spatial utils component seems to[ take these and add them to extraprop](https://github.com/apache/superset/blob/ed47ceb1e4271154f468d21acd12dbfe768abd4f/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/spatialUtils.ts#L210)s. These extraProps then [seem to be made available](https://github.com/apache/superset/blob/ed47ceb1e4271154f468d21acd12dbfe768abd4f/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Geojson/Geojson.tsx#L85) to the features of the geojson and used for tooltips? Maybe I'm misunderstanding the code though, I didn't have a very detailed look at all of this. A similar mechanism could be used to customise the features styling directly from the user's data, and this would also allow per-point customisation. but maybe this is overkill? In any case, there are definitely some properties for the text that I think are very interesting in a general way: - getTextColor - getTextSize - gettextAnchor - getTextBackgroundColor - textFontFamily For the icons, here I'm not sure at all, so I don't have much feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
