aminghadersohi commented on code in PR #35333: URL: https://github.com/apache/superset/pull/35333#discussion_r2389247135
########## superset/sql/dialects/pinot.py: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +MySQL ANSI dialect for Apache Pinot. + +This dialect is based on MySQL but follows ANSI SQL quoting conventions where +double quotes are used for identifiers instead of string literals. +""" + +from __future__ import annotations + +from sqlglot.dialects.mysql import MySQL + + +class Pinot(MySQL): + """ + MySQL ANSI dialect used by Apache Pinot. + + The main difference from standard MySQL is that double quotes (") are used for + identifiers instead of string literals, following ANSI SQL conventions. + """ + + class Tokenizer(MySQL.Tokenizer): + QUOTES = ["'"] # Only single quotes for strings + IDENTIFIERS = ['"', "`"] # Backticks and double quotes for identifiers + STRING_ESCAPES = ["'", "\\"] # Remove double quote from string escapes Review Comment: nit: should these have type hints? ``` class Tokenizer(MySQL.Tokenizer): QUOTES: list[str] = ["'"] IDENTIFIERS: list[str] = ['"', "`"] STRING_ESCAPES: list[str] = ["'", "\\"] ``` ########## tests/unit_tests/sql/dialects/pinot_tests.py: ########## @@ -0,0 +1,340 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import pytest +import sqlglot + +from superset.sql.dialects.pinot import Pinot + + Review Comment: do we cover the test that the dialect properly registered? ``` def test_pinot_dialect_registered() -> None: """Test that Pinot dialect is properly registered.""" from superset.sql.parse import SQLGLOT_DIALECTS assert "pinot" in SQLGLOT_DIALECTS assert SQLGLOT_DIALECTS["pinot"] == Pinot ``` ########## superset/sql/dialects/pinot.py: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +MySQL ANSI dialect for Apache Pinot. + +This dialect is based on MySQL but follows ANSI SQL quoting conventions where +double quotes are used for identifiers instead of string literals. +""" + +from __future__ import annotations + +from sqlglot.dialects.mysql import MySQL + + +class Pinot(MySQL): + """ + MySQL ANSI dialect used by Apache Pinot. + + The main difference from standard MySQL is that double quotes (") are used for + identifiers instead of string literals, following ANSI SQL conventions. Review Comment: should we add a link? See: https://calcite.apache.org/javadocAggregate/org/apache/calcite/config/Lex.html#MYSQL_ANSI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
