aminghadersohi opened a new pull request, #35591: URL: https://github.com/apache/superset/pull/35591
### SUMMARY Improves error messages when report execution times out during chart data fetching (CSV/DataFrame generation). When a Celery soft timeout (`SoftTimeLimitExceeded`) occurs while fetching chart data, the error message now includes: - Chart name and ID - Configured timeout value - Actionable suggestions (optimize query or increase timeout) **Problem**: When chart queries exceed Celery's soft timeout during report execution, the timeout exception was caught but provided no context about which chart failed or why. This made debugging customer issues extremely difficult, as seen in the Stonebridge case where an execution ID was assigned but no meaningful error was logged. **Solution**: Enhanced timeout exception classes to accept custom error messages and added detailed error logging with chart context when `SoftTimeLimitExceeded` occurs during chart data fetching. **Note**: This addresses Celery-level timeouts during chart data fetching, which is different from the working timeout check that runs between execution attempts. Both timeout mechanisms now provide better error messages. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before**: ``` A timeout occurred while generating a csv. ``` **After**: ``` Timeout fetching CSV data for chart 'Sales Report' (ID: 691). The chart query exceeded the 1800 second timeout limit. Consider optimizing the chart query or increasing the working timeout. ``` ### TESTING INSTRUCTIONS 1. Create a report with a chart that has a slow database query (or mock a timeout) 2. Set a low working timeout value (e.g., 10 seconds) 3. Trigger the report execution 4. When timeout occurs, check the execution log error message 5. Verify the error message includes chart name, ID, timeout value, and suggestions ### ADDITIONAL INFORMATION - [ ] Has associated issue: Related to customer support investigation (Stonebridge timeout issue) - [ ] Required feature flags: None - [ ] Changes UI: No - [ ] Includes DB Migration: No - [ ] Introduces new feature or API: No - [ ] Removes existing feature or API: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
