geido commented on code in PR #35316:
URL: https://github.com/apache/superset/pull/35316#discussion_r2387478989
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx:
##########
@@ -193,6 +193,11 @@ const AceEditorWrapper = ({
width: ${theme.sizeUnit * 130}px !important;
}
+ .ace_completion-highlight {
+ color: ${theme.colorPrimaryText} !important;
Review Comment:
Might be my eyes, but I feel `colorPrimaryTextActive` is less readable.
@kasiazjc let me know if you have any feedback here.
With `colorPrimaryTextActive`:
<img width="964" height="246" alt="Screenshot 2025-09-29 at 13 34 04"
src="https://github.com/user-attachments/assets/307e48db-0d88-4907-abf1-2c7ec589f391";
/>
With `colorPrimaryText`:
<img width="816" height="249" alt="Screenshot 2025-09-29 at 13 36 34"
src="https://github.com/user-attachments/assets/a916c124-4442-4bbd-8136-42df7bdd20d1";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
