mazeem-arbisoft commented on PR #26200: URL: https://github.com/apache/superset/pull/26200#issuecomment-3411771128
Hi @john-bodley, we have been facing an issue where overwriting a dashboard doesn't go well sometimes. I looked into import code. A bit curious about the following code in import dashboard's import dataset part: <img width="769" height="83" alt="image" src="https://github.com/user-attachments/assets/45856c10-5643-497e-8fa2-d3b68f24c2be"; /> - Why don't we overwrite datasets here? - Apparently from source code it looks like this line is the issue. I think we should pass the overwrite flag received as a part of dashboard import request. Apparently, the import code never goes into the sync flow in `import_dataset` method if dataset already exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
