github-advanced-security[bot] commented on code in PR #35478: URL: https://github.com/apache/superset/pull/35478#discussion_r2402361620
########## superset/views/streaming.py: ########## @@ -0,0 +1,449 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Streaming HTTP responses for large dataset exports.""" + +from __future__ import annotations + +import logging +import time +import uuid +from datetime import datetime +from typing import Any, Generator, TYPE_CHECKING + +from flask import current_app as app, Response +from werkzeug.datastructures import Headers + +from superset.views.streaming_progress import progress_tracker + +if TYPE_CHECKING: + from superset.common.query_context import QueryContext + +logger = logging.getLogger(__name__) + + +def create_streaming_csv_response_simple( + data_generator: Generator[str, None, None], + filename: str = "export.csv", + encoding: str = "utf-8", +) -> Response: + """ + Create a simple streaming CSV response using Flask's standard pattern. + + This follows the official Flask streaming documentation pattern. + """ + from flask import Response + + # Create response with proper headers + response = Response( + data_generator, Review Comment: ## Information exposure through an exception [Stack trace information](1) flows to this location and may be exposed to an external user. [Show more details](https://github.com/apache/superset/security/code-scanning/2059) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
