panrach commented on issue #33738: URL: https://github.com/apache/superset/issues/33738#issuecomment-3403349817
Thank you for the feedback! We also originally thought that the second bullet was unnecessary, but we caught a problem with this approach when writing unit tests. If we exclude the second point and don't return early, there are 2 problems that happen: 1. Without grouping, rather than displaying "no results returned", a histogram with no bars gets rendered 2. With grouping, an error gets displayed because `unstack` expects a MultiIndex but the DataFrame is empty With that being said, if the DataFrame is empty after dropping empty values, is returning the empty DataFrame a reasonable approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
