sadpandajoe commented on code in PR #35622:
URL: https://github.com/apache/superset/pull/35622#discussion_r2433662325
##########
superset/utils/slack.py:
##########
@@ -104,7 +133,19 @@ def get_channels_with_search(
force=force,
cache_timeout=app.config["SLACK_CACHE_TIMEOUT"],
)
- except (SlackClientError, SlackApiError) as ex:
+ except SlackApiError as ex:
+ # Check if it's a rate limit error
+ if ex.response and ex.response.status_code == 429:
+ raise SupersetException(
+ f"Slack API rate limit exceeded: {ex}. "
+ "For large workspaces (10k+ channels), consider increasing "
+ "SLACK_API_RATE_LIMIT_RETRY_COUNT (current default: 5, try 10)
"
+ "and SLACK_CACHE_TIMEOUT (recommended: 7 days). "
Review Comment:
Same here, if someone has cash higher, then we're suggesting to lower it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
